[CI] Drop ascend scheduler from test #4613
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes all tests related to the AscendScheduler, including the entire E2E test file and several unit tests. However, the implementation code for the AscendScheduler and its configuration (AscendSchedulerConfig) still exists in the codebase (e.g., in vllm_ascend/ascend_config.py, vllm_ascend/platform.py, and vllm_ascend/core/schedule_config.py). Leaving this feature code without any tests is a critical issue, as it becomes dead code that is hard to maintain and can lead to silent breakages. If the AscendScheduler is being deprecated, its implementation should be removed along with the tests. If it is not being deprecated, the tests should be restored or replaced.
wangxiyuan
force-pushed
the
drop_ascend_scheduler_test
branch
2 times, most recently
from
3e1d5d5 to
5cd62f5
Compare
MengqingCao
added
ready
|
LGTM if all ci pass |
Signed-off-by: wangxiyuan <[email protected]>
wangxiyuan
force-pushed
the
drop_ascend_scheduler_test
branch
from
5cd62f5 to
94a3c82
Compare
|
@MengqingCao No need to run e2e IMO |
Drop ascend scheduler from test - vLLM version: v0.11.2 Signed-off-by: wangxiyuan <[email protected]>
Drop ascend scheduler from test - vLLM version: v0.11.2 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Drop ascend scheduler from test - vLLM version: v0.11.2 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Che Ruan <[email protected]>
Drop ascend scheduler from test - vLLM version: v0.11.2 Signed-off-by: wangxiyuan <[email protected]>
Drop ascend scheduler from test - vLLM version: v0.11.2 Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: tanqingshan (A) <[email protected]>
2 participants
Drop ascend scheduler from test